Finishes client config refactor refactor and increases test coverage - #190
Merged
Conversation
Here we separate the editor from the config file metadata operations. this allows us to keep operaions decoupled and to avoid bleeding logic into the wrong layers. we also add missing tests for the FindClientConfigs method that greatly increases our test coverage as well as adding tests for the ToolHive config file package where there were none before. Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
ChrisJBurns
changed the title
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
…ve into cleanup-config-file-code
JAORMX
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We finish off the Client config refactor by:
FindClientConfigsmethod that greatly increases our test coverage as well as adding tests for the config package that was responsible for handling the ToolHive config file where there were none before.Resolves: #117