Update standalone-SSE test for filtered-tool error - #5958
Merged
Conversation
TestStandaloneSSE_ListChangedRefiltersThroughExistingMiddleware asserted that a tools/call for a filtered tool returns HTTP 400. That is no longer true: #5944 changed the tool-call filter to return a JSON-RPC error over HTTP 200 (a filtered tool is now indistinguishable from a nonexistent one). This test was added by #5934 and the two PRs landed close together, so each was green in isolation but the combination left the Tests check red on main (a semantic merge collision) — deterministically failing every subsequent PR's required unit-test job. Update step (3) to assert the current behavior: HTTP 200 with a JSON-RPC error body ("tool not found"). The tool is still blocked (never forwarded); only the response envelope changed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
JAORMX
requested review from
ChrisJBurns,
amirejaz,
blkt,
jhrozek and
rdimitrov
as code owners
July 24, 2026 06:32
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5958 +/- ##
==========================================
+ Coverage 71.80% 71.83% +0.03%
==========================================
Files 708 708
Lines 72767 72798 +31
==========================================
+ Hits 52250 52296 +46
+ Misses 16778 16764 -14
+ Partials 3739 3738 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rdimitrov
approved these changes
Jul 24, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why:
main's required Tests / Test Go Code check is currently red on every PR.TestStandaloneSSE_ListChangedRefiltersThroughExistingMiddleware(pkg/transport/proxy/streamable/dispatcher_standalone_sse_integration_test.go:468) asserts that atools/callfor a filtered tool returns HTTP 400 — but #5944 changed the tool-call filter to return a JSON-RPC error over HTTP 200 (a filtered tool is now indistinguishable from a nonexistent one). The test was added by #5934; #5934 and #5944 landed close together, so each was green in isolation but their combination is a semantic merge collision that leaves the unit-test suite deterministically failing onmain.What:
"tool not found". The tool is still blocked (never forwarded to the backend); only the response envelope changed.Verified locally: the test failed deterministically before this change and passes after;
task lintclean.Type of change
Test plan
go test -race -run TestStandaloneSSE_ListChangedRefiltersThroughExistingMiddleware ./pkg/transport/proxy/streamable/passes (failed before the change).task lint0 issues.Does this introduce a user-facing change?
No. Test-only change aligning an assertion with the behavior shipped in #5944.
Special notes for reviewers
Generated with Claude Code