Skip to content

Implement horizontal fly speed#191

Merged
stackotter merged 3 commits into
stackotter:mainfrom
FloofyPlasma:main
May 23, 2024
Merged

Implement horizontal fly speed#191
stackotter merged 3 commits into
stackotter:mainfrom
FloofyPlasma:main

Conversation

@FloofyPlasma
Copy link
Copy Markdown
Contributor

Description

This PR implements the horizontal fly speed to match the vanilla client. A frame-by-frame analysis was performed and it matches minus some minor frame timing discrepancies.

Partially fixes #178

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation comments
  • My changes generate no new warnings

Copy link
Copy Markdown
Owner

@stackotter stackotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌 Just one formatting change to make (trailing newlines) but other than that it's ready to merge once the workflows finish

Comment thread Sources/Core/Sources/ECS/Systems/PlayerAccelerationSystem.swift Outdated
@FloofyPlasma
Copy link
Copy Markdown
Contributor Author

Removed the trailing newline

Copy link
Copy Markdown
Owner

@stackotter stackotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 🎉

@stackotter stackotter merged commit 04539f9 into stackotter:main May 23, 2024
stackotter pushed a commit that referenced this pull request May 24, 2024
stackotter pushed a commit that referenced this pull request Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix flying speed to match vanilla

2 participants