fix(tests): retry fact health_check more times#914
Merged
Conversation
After adding some more test platforms through #760, some tests have started failing with the claim that fact failed to start. Upon reviewing the logs it turns out fact sometimes take slightly longer to start, so increasing the number of times we retry the health_check endpoint should be enough to mitigate this flake.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #914 +/- ##
=======================================
Coverage 32.72% 32.72%
=======================================
Files 21 21
Lines 2695 2695
Branches 2695 2695
=======================================
Hits 882 882
Misses 1810 1810
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After adding some more test platforms through #760, some tests have started failing with the claim that fact failed to start. Upon reviewing the logs it turns out fact sometimes take slightly longer to start, so increasing the number of times we retry the health_check endpoint should be enough to mitigate this flake.
Examples of the flake:
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
CI should be enough. Will monitor CI after merging to check the flake is properly gone.