Allow configuration of ring buffer depth#11
Closed
Molter73 wants to merge 1 commit into
Closed
Conversation
11 tasks
Collaborator
|
Interesting, thanks for the PR. Is there any intuition about how to choose the right value (i.e. not too low, not too high)? |
Member
Author
|
By default in the falcosecurity/libs repository it is using an 8MB ring buffer, I have no idea how they came up with that number. I'm assuming that in our case, 8MB was insufficient and at some point we were missing events and was doubled to 16MB, @robbycochran might have more insight into this. |
Molter73
force-pushed
the
mauro/ROX-9418-allow-ringbuffer-depth-config
branch
from
May 30, 2022 13:05
5b5c6a0 to
12735ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the necessary changes to allow for the ring buffer depth to be set at build time. The naming chosen for the multiplier define might not be the best.