Problems
SPEC.md gaps
harness preflight missing --strict flag in CLI signatureharness preflight available and harness preflight names subcommands undocumentedharness providers description incomplete: missing providers_v2 enablement, custom profile import, hardcoded provider list, OPENSHELL_MODEL env var, --force behaviorharness deploy bracket notation [--local|--remote] implies both are optional; code requires one- Testing section only documents bash tests; Go unit tests (28+) not mentioned
- Environment variables section missing: OPENSHELL_CLI, OPENSHELL_MODEL, HARNESS_DIR
Code DRY
internal/preflight/check.go: config path resolution (PROVIDERS_TOML/CONFIG_TOML env var + fallback) copy-pasted 3 times across RunCheck, RunAvailable, RunNames
Fix: Extract loadEnabledProviders(harnessDir) ([]Provider, error) helper.
Severity: Medium (spec), Low (DRY)
Found by: 5-dimension code audit (spec accuracy + code quality review)
Problems
SPEC.md gaps
harness preflightmissing--strictflag in CLI signatureharness preflight availableandharness preflight namessubcommands undocumentedharness providersdescription incomplete: missing providers_v2 enablement, custom profile import, hardcoded provider list, OPENSHELL_MODEL env var, --force behaviorharness deploybracket notation[--local|--remote]implies both are optional; code requires oneCode DRY
internal/preflight/check.go: config path resolution (PROVIDERS_TOML/CONFIG_TOML env var + fallback) copy-pasted 3 times across RunCheck, RunAvailable, RunNamesFix: Extract
loadEnabledProviders(harnessDir) ([]Provider, error)helper.Severity: Medium (spec), Low (DRY)
Found by: 5-dimension code audit (spec accuracy + code quality review)