refactor: extract shared createSandbox function#48
Merged
Conversation
Both upLocal (up.go) and createDirect (create.go) contained near-duplicate sandbox creation logic: image resolution, file staging, retry loop, and failure cleanup. Extract this into a single createSandbox function in cmd/sandbox.go, parameterized by a sandboxOpts struct that captures the differences (noTTY, retrySleep, sandboxCmd, onSuccess callback). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upLocal(cmd/up.go) andcreateDirect(cmd/create.go) into a sharedcreateSandboxfunction in a newcmd/sandbox.gofilesandboxOptsstruct capturing their specific parameters (noTTY, retrySleep, sandboxCmd, onSuccess callback) then delegate tocreateSandboxTest plan
cmd/up_test.gopass (including retry, SandboxCreateOpts, missing providers)cmd/create_test.gopass (including no providers, with providers, sandbox name)CGO_ENABLED=0 go test ./cmd/...passesgo vet ./...passesinternal/packages,providers.toml,go.work, or files outsidecmd/🤖 Generated with Claude Code