chore: pre-0.1 release audit#51
Merged
Merged
Conversation
Security: - Delete plans/ dir (contained plaintext quay.io credentials) - Delete credentials.md, PROVIDERS-SPEC.md, todo-improve.md, docs/profile-concepts.md (all reference deleted code) - Add --material to verbose redaction (was leaking client_secret) - Gitignore plans/, openshell-arch/, strategy-dashboard.html Bugs fixed: - gwsProfileScopes() path: sandbox/profiles -> agents/providers/profiles - deploy_test.go TOML fixture: launcher -> runner image key - .goreleaser.yaml: add binary: harness (was defaulting to harness-openshell) New: - harness --version flag with goreleaser ldflags injection - SPEC.md fully rewritten for agents/*.yaml, harness launch, -f flag - TODO.md rewritten with current roadmap Updated: - AGENTS.md: launcher -> runner, --profile -> --agent - Test setup dirs: sandbox/profiles -> agents/providers/profiles - Stale comments in sandbox.go, providers.go, startup.sh, openshell.toml - README references section: removed deleted PROVIDERS-SPEC.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pre-release audit found and fixed security issues, bugs, and stale docs.
Security:
plans/directory (contained plaintext quay.io credentials -- rotate token)--materialto verbose redaction (was leaking GWS client_secret/refresh_token)credentials.md,PROVIDERS-SPEC.md,todo-improve.md,docs/profile-concepts.mdBugs fixed:
gwsProfileScopes()read from deletedsandbox/profiles/gws.yaml(GWS OAuth scopes never applied)deploy_test.goTOML fixture usedlauncherkey (runner image override silently untested).goreleaser.yamlmissingbinary: harness(release binaries would be namedharness-openshell)New:
harness --versionflag with goreleaser ldflags injectionSPEC.mdfully rewritten for agents/*.yaml, harness launch, -f flagTODO.mdrewritten with current roadmapUpdated: AGENTS.md, test fixtures, stale comments, .gitignore, README references
Net
-673 lines. Deleted 5 stale docs, fixed 3 bugs, added version support.
Test plan
go vet ./...+go test ./...passharness --versionoutputsharness version dev