refactor: remove dead code and redundant patterns

[robbycochran]

Summary

Cleanup based on multi-perspective workflow findings that scanned the codebase from 5 different angles (dead code, finished TODOs, redundant docs/code/plans) with adversarial verification.

Net result: -152 lines (217 deleted, 65 added)

Changes

Dead Code Removal

• ✅ Removed Parse(), ParseFile(), BuildSandboxEnv() from internal/profile
  • These functions were never called in production code (only tests)
  • Represents abandoned TOML-based profile configuration approach
• ✅ Simplified StageHarnessDir() to only create directory (payload rendering moved to agent package)
• ✅ Updated tests to match streamlined profile package
• ✅ Added build/runner/openshell and harness-openshell to .gitignore

Code Deduplication

• ✅ Extracted resolveSandboxImage() helper
  • Eliminates duplicate logic in create.go, up.go, launch.go
  • Consistent precedence: SANDBOX_IMAGE env > agent config > default
• ✅ Replaced custom providerInList() with slices.Contains from stdlib (Go 1.21+)

Documentation Cleanup

• ✅ Archived docs/design.md → docs/archive/design-v1-2026-06-08.md
  • 485-line design proposal with outdated naming (harness.toml vs openshell.toml, profiles/*.toml vs agents/*.yaml)
  • Implementation diverged on 2026-06-08; marked as historical reference
  • Added docs/archive/README.md explaining archived content
• ✅ Updated plans/nemoclaw-arch.md gap analysis
  • Marked lifecycle commands (status, logs, start, stop) as complete (PR feat: lifecycle commands, output formatting, and show-commands mode #54)
• ✅ Updated TODO.md to reflect partial completion of profile consolidation

Deleted Scratch Files

• Removed untracked/gitignored planning artifacts:
  • demo.md (superseded by demo/ directory)
  • fix-startup.md, remainingbanners.md (debugging notes for completed PR fix: add claude wrapper to skip sandbox startup modals #53)
  • dashboard.html, strategy-dashboard.html (planning artifacts)
  • plans/ocp-sandbox.sh, plans/verify-integrations.py (unreferenced scripts)

Testing

• ✅ All internal/profile tests pass
• ✅ Code compiles successfully (go build .)
• ✅ No production functionality changes (pure refactoring)

Next Steps

Remaining work identified in TODO.md:

• Move ValidateProviders to agent or gateway package
• Inline Config struct into sandbox.go
• Remove TOML dependency if no longer needed elsewhere

---

Generated via multi-agent workflow: 56 agents, 51 findings → 28 confirmed after adversarial verification