refactor: cleanup, CI fixes, and test coverage#57
Merged
Conversation
- Add bats to CI unit job; skip image push on PRs (fork-safe) - Remove internal/profile package (dead code, replaced by provider system) - Add launch and gateway validate test coverage - Move bats install out of integration jobs; use kind install_only - Tighten Makefile, dev-harness.sh, and test scripts
- Add `go build -o harness .` before `bats test/preflight.bats` in CI: bats tests use `$REPO_ROOT/harness` which must exist. - Add "Wait for gateway" step to kind job (mirrors local job): removing the `test` Makefile prerequisite from `test-kind` eliminated the ~2min grace period the bats run accidentally provided, causing `harness up` to hit a not-yet-ready local openshell service.
The podman save + kind load image-archive step takes 60-90s and can make the local openshell service unresponsive by the time test-flow.sh runs. Poll for up to 60s immediately before handing off to tests.
The podman save + kind load image-archive step takes ~70s and leaves the local openshell service unresponsive. Restart it via systemctl before running test-flow.sh, which uses `harness up` (no --remote) and depends on the local gateway being reachable.
The podman save + kind load archive transfer takes ~70s and starves the local openshell service, making it unresponsive for subsequent tests. Run a background keep-alive loop that pings the gateway every 5s during the transfer instead of restarting after the fact.
The openshell daemon briefly reloads its config after `openshell gateway add` runs during `deploy kind`, making it transiently unresponsive. Retry InferenceGet up to 5 times with 3s intervals so harness up can proceed once the daemon finishes reloading.
images.yml: push sandbox/runner images on same-repo PRs (not fork PRs), so the integration kind job can pull the image from the registry. kind-lifecycle.sh: skip the 60-90s podman save+load preload in CI (CI=true). The preload disrupted the local openshell service; in CI the image is now available in the registry. Local dev still preloads from the container daemon for fast iteration without a registry push.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup and dead code removal:
CI: bats integration in unit job:
CI: image push policy:
CI: kind integration fixes:
Test plan