fix: use git describe for image tags, add make tag#64
Merged
Conversation
The images workflow was tagging with bare short SHAs (sandbox-abc1234) which did not match the Makefile's VERSION (git describe output like v0.1.2-12-gabcdef0). Now non-tag pushes tag with the full git describe output so the image tag matches what make cli embeds. Tag pushes still produce clean semver tags (sandbox-v0.2.0). Added make tag v=X.Y.Z convenience target for creating release tags.
Harness-specific env vars now use HARNESS_OS_ prefix: HARNESS_OS_DIR (was HARNESS_DIR) HARNESS_OS_IMAGE (was SANDBOX_IMAGE) HARNESS_OS_GATEWAY (was GATEWAY_NAME) HARNESS_OS_PULL_SECRET (was PULL_SECRET) HARNESS_OS_SANDBOX_PULL_SECRET (was SANDBOX_PULL_SECRET) OpenShell runtime vars keep OPENSHELL_ prefix: OPENSHELL_CLI, OPENSHELL_NAMESPACE, OPENSHELL_MODEL, OPENSHELL_CHART_VERSION Also renamed DEV_SANDBOX_IMAGE to IMAGE in Makefile.
Pipe output through sed to remove ANSI escape sequences before writing to the log file. The log artifacts are now clean ASCII text.
The kind-lifecycle script was skipping image preload when CI=true, forcing the kind cluster to pull from the registry at sandbox create time. This caused slow or stuck pulls for the ~800MB sandbox image. Now the locally-built image is always preloaded into kind via 'kind load docker-image' when available, regardless of CI mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git describe --tags --alwaysoutput (e.g.,sandbox-v0.1.2-12-gabcdef0) instead of bare short SHAs (sandbox-abc1234), matching what the Makefile embeds viaVERSIONsandbox-v0.2.0)fetch-depth: 0to images workflow checkout sogit describehas tag historymake tag v=0.2.0convenience target for creating annotated release tagsTest plan
make testpassesgit describeoutput