Conversation
msugakov
approved these changes
Jun 1, 2021
porridge
added a commit
that referenced
this pull request
Dec 2, 2021
porridge
added a commit
that referenced
this pull request
Dec 15, 2021
porridge
added a commit
that referenced
this pull request
Dec 17, 2021
* Revert Translator commits. Revert "Pass context to Translate(). (#8)" This reverts commit c3df552. Revert "Add a WithValueTranslator option to Reconciller. (#6)" This reverts commit 88508a2. * Add a WithValueTranslator option to Reconciller (cherry-picked from upstream PR). A Translator is a way to produces helm values based on the fetched custom resource itself (unlike `Mapper` which can only see `Values`). This way the code which converts the custom resource to Helm values can first convert an `Unstructured` into a regular struct, and then rely on Go type safety rather than work with a tree of maps from `string` to `interface{}`. Thanks to having access to a `Context`, the code can also safely access the network, for example in order to retrieve other resources from the k8s cluster, when they are referenced by the custom resource.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary for proper deadline propagation in case
Translatetalks to the network.