Skip to content

Make --early-readiness the default #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mclasmeier merged 1 commit into from
Dec 17, 2025
Merged

Make --early-readiness the default #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ Red Hat Advanced Cluster Security (ACS) on any Kubernetes/OpenShift cluster.`,

func init() {
rootCmd.PersistentFlags().BoolVarP(&verbose, "verbose", "v", false, "Enable verbose output (show CRs and Helm values)")
rootCmd.PersistentFlags().BoolVar(&earlyReadiness, "early-readiness", false, "Only wait for essential workloads (central/sensor), not all workloads")
rootCmd.PersistentFlags().BoolVar(&earlyReadiness, "early-readiness", true, "Only wait for essential workloads (central/sensor) to be ready")
rootCmd.AddCommand(newDeployCmd())
rootCmd.AddCommand(newTeardownCmd())
rootCmd.AddCommand(newVersionCmd())
Expand Down
9 changes: 5 additions & 4 deletions tests/e2e/e2e_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,10 @@ const (
)

var (
commonDeployArgs = []string{"--port-forwarding", "--exposure=none", "--resources=small", "--early-readiness"}
commonDeployArgsNoPortForward = []string{"--exposure=loadbalancer", "--resources=small", "--early-readiness"}
roxieBinary string
commonDeployArgs = []string{"--port-forwarding", "--exposure=none", "--resources=small"}
commonDeployArgsNoPortForward = []string{"--exposure=loadbalancer", "--resources=small"}

roxieBinary string
)

func TestMain(m *testing.M) {
Expand Down Expand Up @@ -293,7 +294,7 @@ func TestDeployBothComponentsTogether(t *testing.T) {

t.Log("=== Deploying both components ===")
// We also test --pause-reconciliation flag here.
args := append([]string{roxieBinary, "deploy", "both", "--early-readiness", "--pause-reconciliation", "--envrc", envrcPath}, commonDeployArgsNoPortForward...)
args := append([]string{roxieBinary, "deploy", "both", "--pause-reconciliation", "--envrc", envrcPath}, commonDeployArgsNoPortForward...)
runCommand(t, deployTimeout*2, nil, args...)

t.Log("Verifying namespace: acs-central")
Expand Down