Skip to content

Export ROX_USERNAME (expected by some test suites) #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mclasmeier merged 2 commits into from
Apr 15, 2026
Merged

Export ROX_USERNAME (expected by some test suites) #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14a2de5
Export ROX_USERNAME (expected by some test suites)
Apr 15, 2026
3a16660
Use %q
Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions cmd/subshell.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,21 +32,22 @@ func spawnSubshell(d *deployer.Deployer, log *logger.Logger) error {
endpoint, password, caCertFile, kubeContext, exposure := d.GetDeploymentInfo()

if endpoint != "" {
env = append(env, fmt.Sprintf("API_ENDPOINT=%s", endpoint))
env = append(env, fmt.Sprintf("ROX_ENDPOINT=%s", endpoint))
env = append(env, fmt.Sprintf("ROX_BASE_URL=https://%s", endpoint))
env = append(env, fmt.Sprintf("API_ENDPOINT=%q", endpoint))
env = append(env, fmt.Sprintf("ROX_ENDPOINT=%q", endpoint))
env = append(env, fmt.Sprintf("ROX_BASE_URL='https://%s'", endpoint))
}

if password != "" {
env = append(env, fmt.Sprintf("ROX_ADMIN_PASSWORD=%s", password))
env = append(env, fmt.Sprintf("ROX_ADMIN_PASSWORD=%q", password))
}

if caCertFile != "" {
env = append(env, fmt.Sprintf("ROX_CA_CERT_FILE=%s", caCertFile))
env = append(env, fmt.Sprintf("ROX_CA_CERT_FILE=%q", caCertFile))
}

env = append(env, fmt.Sprintf("ROX_USERNAME=%q", deployer.AdminUsername))
env = append(env, "ROXIE_SHELL=1")
env = append(env, fmt.Sprintf("name=acs@%s", kubeContext))
env = append(env, fmt.Sprintf("name='acs@%s'", kubeContext))

haproxyAvailable := isHAProxyAvailable()

Expand All @@ -60,7 +61,7 @@ func spawnSubshell(d *deployer.Deployer, log *logger.Logger) error {
if err != nil {
log.Warningf("Failed to start HAProxy: %v", err)
} else {
env = append(env, fmt.Sprintf("ROXIE_HAPROXY_CFG_FILE=%s", haproxyConfigPath))
env = append(env, fmt.Sprintf("ROXIE_HAPROXY_CFG_FILE=%q", haproxyConfigPath))
haproxyStarted = true
defer cleanupHAProxy(haproxyCmd, haproxyConfigPath)
}
Expand Down
18 changes: 11 additions & 7 deletions internal/deployer/deployer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ var (

pauseReconcileAnnotationKey = "stackrox.io/pause-reconcile"

// AdminUsername is the default admin username for StackRox Central
AdminUsername = "admin"

// TODO(#91): at some point this will get out of date. If we filter by the app.../part-of
// label anyway, then maybe we should just delete all resource kinds present on cluster?
// also we should use the fully-qualified types
Expand Down Expand Up @@ -1071,14 +1074,15 @@ func (d *Deployer) cleanupTempDir(path string, description string) {
func (d *Deployer) writeEnvrcFile(ctx context.Context, exposure string, portForwardWanted bool) error {
endpoint := strings.TrimPrefix(d.centralEndpoint, "https://")

content := fmt.Sprintf(`export API_ENDPOINT="%s"
export ROX_ENDPOINT="%s"
export ROX_BASE_URL="https://%s"
export ROX_ADMIN_PASSWORD="%s"
export ROX_CA_CERT_FILE="%s"
`, endpoint, endpoint, endpoint, d.centralPassword, d.roxCACertFile)
var content strings.Builder
fmt.Fprintf(&content, "export API_ENDPOINT=%q\n", endpoint)
fmt.Fprintf(&content, "export ROX_ENDPOINT=%q\n", endpoint)
fmt.Fprintf(&content, "export ROX_BASE_URL='https://%s'\n", endpoint)
fmt.Fprintf(&content, "export ROX_USERNAME=%q\n", AdminUsername)
fmt.Fprintf(&content, "export ROX_ADMIN_PASSWORD=%q\n", d.centralPassword)
fmt.Fprintf(&content, "export ROX_CA_CERT_FILE=%q\n", d.roxCACertFile)

if err := os.WriteFile(d.envrcFile, []byte(content), 0600); err != nil {
if err := os.WriteFile(d.envrcFile, []byte(content.String()), 0600); err != nil {
return fmt.Errorf("failed to write envrc file: %w", err)
}

Expand Down
Loading