Skip to content

feat: remove at-block in 3.4#6937

Merged
aaronb-stacks merged 13 commits intostacks-network:developfrom
francesco-stacks:feat/remove-at-block
Mar 11, 2026
Merged

feat: remove at-block in 3.4#6937
aaronb-stacks merged 13 commits intostacks-network:developfrom
francesco-stacks:feat/remove-at-block

Conversation

@francesco-stacks
Copy link
Contributor

@francesco-stacks francesco-stacks commented Feb 26, 2026

Description

Implementation of SIP proposal: stacksgov/sips#262

  • disable at-block in clarity1-4, both at deploy-time for new contracts, and at runtime for contracts already deployed.
  • remove at-block completely in clarity5+.
  • adjusts tests using at-block.

Applicable issues

  • fixes #

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • For new Clarity features or consensus changes, add property tests (see docs/property-testing.md)
  • Changelog is updated
  • Required documentation changes (e.g., rpc/openapi.yaml for RPC endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo

@francesco-stacks francesco-stacks self-assigned this Feb 26, 2026
@francesco-stacks francesco-stacks changed the title feat: disable at-block in 3.4 feat: deprecate at-block in 3.4 Feb 28, 2026
@francesco-stacks francesco-stacks marked this pull request as ready for review February 28, 2026 20:17
@francesco-stacks francesco-stacks moved this to Status: In Review in Stacks Core Eng Mar 2, 2026
@francesco-stacks francesco-stacks changed the title feat: deprecate at-block in 3.4 feat: remove at-block in 3.4 Mar 3, 2026
Copy link
Contributor

@brice-stacks brice-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Can you just update clarity/src/vm/docs/mod.rs with the change that at-block is no longer supported after epoch 3.4?

@francesco-stacks
Copy link
Contributor Author

This looks good to me. Can you just update clarity/src/vm/docs/mod.rs with the change that at-block is no longer supported after epoch 3.4?

added in 399daf9

brice-stacks
brice-stacks previously approved these changes Mar 6, 2026
Copy link
Contributor

@brice-stacks brice-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; just one question.

Copy link
Contributor

@aaronb-stacks aaronb-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaronb-stacks aaronb-stacks enabled auto-merge March 11, 2026 17:51
@aaronb-stacks aaronb-stacks added this pull request to the merge queue Mar 11, 2026
Merged via the queue into stacks-network:develop with commit 962e7ab Mar 11, 2026
334 of 338 checks passed
@github-project-automation github-project-automation bot moved this from Status: In Review to Status: ✅ Done in Stacks Core Eng Mar 11, 2026
@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.36%. Comparing base (56a1a1e) to head (b4dd046).
⚠️ Report is 14 commits behind head on develop.

❌ Your project status has failed because the head coverage (64.36%) is below the adjusted base coverage (73.38%). You can increase the head coverage or adjust the Removed Code Behavior.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6937      +/-   ##
===========================================
- Coverage    73.38%   64.36%   -9.02%     
===========================================
  Files          412      412              
  Lines       219352   219362      +10     
  Branches       338      338              
===========================================
- Hits        160976   141201   -19775     
- Misses       58376    78161   +19785     
Files with missing lines Coverage Δ
clarity-types/src/errors/analysis.rs 73.66% <100.00%> (+2.74%) ⬆️
...y/src/vm/analysis/type_checker/v2_1/natives/mod.rs 85.16% <100.00%> (-1.55%) ⬇️
clarity/src/vm/docs/mod.rs 6.12% <ø> (-71.32%) ⬇️
clarity/src/vm/functions/database.rs 87.11% <100.00%> (-1.50%) ⬇️
clarity/src/vm/functions/mod.rs 96.93% <ø> (+1.02%) ⬆️
stacks-common/src/types/mod.rs 77.18% <100.00%> (-0.58%) ⬇️

... and 270 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56a1a1e...b4dd046. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants