feat: remove at-block in 3.4#6937
Conversation
at-block in 3.4
at-block in 3.4at-block in 3.4
...ate__tests__runtime_analysis_tests__runtime_check_error_kind_at_block_unavailable_ccall.snap
Show resolved
Hide resolved
...b__chainstate__tests__runtime_analysis_tests__runtime_check_error_kind_type_error_ccall.snap
Show resolved
Hide resolved
..._chainstate__tests__runtime_analysis_tests__runtime_check_error_kind_type_error_cdeploy.snap
Show resolved
Hide resolved
...nstate/tests/snapshots/blockstack_lib__chainstate__tests__runtime_tests__bad_block_hash.snap
Show resolved
Hide resolved
...ts/snapshots/blockstack_lib__chainstate__tests__runtime_tests__block_time_not_available.snap
Show resolved
Hide resolved
...pshots/blockstack_lib__chainstate__tests__runtime_tests__unknown_block_header_hash_fork.snap
Show resolved
Hide resolved
...te__tests__static_analysis_tests__static_check_error_at_block_closure_must_be_read_only.snap
Show resolved
Hide resolved
brice-stacks
left a comment
There was a problem hiding this comment.
This looks good to me. Can you just update clarity/src/vm/docs/mod.rs with the change that at-block is no longer supported after epoch 3.4?
added in 399daf9 |
962e7ab
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (64.36%) is below the adjusted base coverage (73.38%). You can increase the head coverage or adjust the Removed Code Behavior. Additional details and impacted files@@ Coverage Diff @@
## develop #6937 +/- ##
===========================================
- Coverage 73.38% 64.36% -9.02%
===========================================
Files 412 412
Lines 219352 219362 +10
Branches 338 338
===========================================
- Hits 160976 141201 -19775
- Misses 58376 78161 +19785
... and 270 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Description
Implementation of SIP proposal: stacksgov/sips#262
at-blockin clarity1-4, both at deploy-time for new contracts, and at runtime for contracts already deployed.at-blockcompletely in clarity5+.at-block.Applicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/property-testing.md)rpc/openapi.yamlfor RPC endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepo