fix(hono): return 204 for void handler results instead of crashing#108
Merged
fix(hono): return 204 for void handler results instead of crashing#108
Conversation
dgellow
force-pushed
the
sam/fix-hono-plugin
branch
2 times, most recently
from
2dd0b25 to
211d4ef
Compare
Hono 4.12 added a fast path in `Context.json()` that uses the static `Response.json()` method. Unlike the previous `JSON.stringify()` + `new Response()` path, `Response.json(undefined)` throws `TypeError: Value is not JSON serializable`. Any stl endpoint handler that returns void (e.g. webhook handlers that do work but have no meaningful response) hits `c.json(undefined)` in the plugin and crashes with a 500 in production on Hono >= 4.12. Return a 204 No Content when the handler result is `undefined`, which is the correct HTTP semantic for "request succeeded, no body".
dgellow
force-pushed
the
sam/fix-hono-plugin
branch
from
211d4ef to
3fa2af2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hono 4.12.1 added a fast path in
Context.json()that uses the staticResponse.json()method. Unlike the previousJSON.stringify()+new Response()path,Response.json(undefined)throwsTypeError: Value is not JSON serializable.Any stl endpoint handler that returns void (e.g. webhook handlers that do work but have no meaningful response) hits
c.json(undefined)in the plugin and crashes with a 500 in production on Hono >= 4.12.Return a 204 No Content when the handler result is
undefined, which is the correct HTTP semantic for "request succeeded, no body".It's fixed in hono 4.12.2 as far as I can tell