Use melt_mcmc instead of calling reshape2::melt#246
Conversation
Codecov Report
@@ Coverage Diff @@
## master #246 +/- ##
==========================================
- Coverage 98.34% 98.34% -0.01%
==========================================
Files 32 32
Lines 4112 4111 -1
==========================================
- Hits 4044 4043 -1
Misses 68 68
Continue to review full report at Codecov.
|
| } | ||
|
|
||
| data <- reshape2::melt(x, value.name = "Value") | ||
| data$Chain <- factor(data$Chain) |
There was a problem hiding this comment.
Is there a reason to also get rid of making Chain a factor? To be honest I'm not sure why that was there in the first place (it may never have been necessary, maybe I thought tapply required factors), but curious if you removed that intentionally?
There was a problem hiding this comment.
I removed it intentionally. I didn’t think it was necessary as tapply calls as.factor on INDEX anyway.
jgabry
left a comment
jgabry
left a comment
There was a problem hiding this comment.
Good catch, thanks for this! I just put one tiny question below (or above, wherever it ends up).
jgabry
left a comment
jgabry
left a comment
There was a problem hiding this comment.
Thanks again for the PR. Merging now.
3 participants
Closes #245 (tests pass locally for me)