Skip to content

Handle deprecation of aes_ (ggplot2) and .data (tidyselect)#292

Merged
jgabry merged 6 commits into
patch-for-cranfrom
aes_-deprecation
Nov 13, 2022
Merged

Handle deprecation of aes_ (ggplot2) and .data (tidyselect)#292
jgabry merged 6 commits into
patch-for-cranfrom
aes_-deprecation

Conversation

@jgabry
Copy link
Copy Markdown
Member

@jgabry jgabry commented Nov 12, 2022

aes_ is now deprecated in ggplot2

.data is deprecated for tidyselect but still used for data masking

@jgabry jgabry linked an issue Nov 12, 2022 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (patch-for-cran@f38d063). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             patch-for-cran     #292   +/-   ##
=================================================
  Coverage                  ?   97.69%           
=================================================
  Files                     ?       35           
  Lines                     ?     4996           
  Branches                  ?        0           
=================================================
  Hits                      ?     4881           
  Misses                    ?      115           
  Partials                  ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jgabry
Copy link
Copy Markdown
Member Author

jgabry commented Nov 13, 2022

Passing except for a vignette failure on windows that isn't related to this PR (there's still an issue running rstan via GitHub actions on windows)

@jgabry jgabry merged commit 998b4b9 into patch-for-cran Nov 13, 2022
@jgabry jgabry deleted the aes_-deprecation branch November 13, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecations in ggplot2 and tidyselect

2 participants