Update dockerfiles for 4.12 - #13
Merged
Merged
Conversation
11 tasks
4.12 version has the opam group built-in
WardBrian
marked this pull request as ready for review
November 15, 2021 19:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@serban-nicusor-toptal I believe this is what is necessary for the new docker build. The only problem is that I need all of the scripts to come from a non-master branch at the moment. The only hardcoded usage of master (I think) is in Dockerfile/multiarch, the rest just use the repo provided during the build in the Jenkinsfile.
Also, I believe this would overwrite the existing images we have? Which means nothing besides my pr would build. Please help me fix this up!