Deprecation schedule for minor (breaking) language changes - #43
Merged
Conversation
bob-carpenter
requested changes
Sep 27, 2021
bob-carpenter
left a comment
bob-carpenter
left a comment
Member
There was a problem hiding this comment.
The main contentful comment here is that we should commit to 3 minor releases or 1 major release for minor deprecations. We should also say anything that's not a minor deprecation as defined here will require a major version bump.
I hope you appreciate the more nitpicky comments rather than finding them annoying.
WardBrian
changed the title
Member
Author
|
I'd like to ask for any more feedback on this. We will be discussing it during Thursday's language meeting and then merging unless there are objections |
rok-cesnovar
self-requested a review
November 9, 2021 19:25
This was referenced Nov 18, 2021
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered version: https://github.com/WardBrian/design-docs/blob/deprecation-schedule/designs/0031-language-deprecation-schedule.md
Prior discussion on forums (largely replicated in the doc): https://discourse.mc-stan.org/t/a-deprecation-schedule-for-stan/24228