Update code in docs for style and deprecations#394
Merged
Conversation
Manual sweep following
bob-carpenter
requested changes
Sep 7, 2021
Member
bob-carpenter
left a comment
There was a problem hiding this comment.
This is fantastic, despite the fact that I need an ice pack for my forearm after all the scrolling. All the code changes look good. Only a few comments/questions.
|
|
||
| <!-- T[]; rep_array; (T x, int n); --> | ||
| \index{{\tt \bfseries rep\_array }!{\tt (T x, int n): T[]}|hyperpage} | ||
| <!-- array[] T; rep_array; (T x, int n); --> |
Member
Member
Author
There was a problem hiding this comment.
They were simply caught by the find-and-replace done for the formatted output. I was assuming the comments were there as a more human-readable note in the source text, that's my bad. I can change them back if it's too much of a problem?
Member
Author
|
@bob-carpenter this is ready for re-review, you should be able to look at just the diff on the most recent 3 commits |
bob-carpenter
approved these changes
Sep 8, 2021
Member
bob-carpenter
left a comment
There was a problem hiding this comment.
Looks great. Thanks for all the updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Summary
Resolves #383. Fixes spacing and syntax in all examples:
array[] Tsyntax overT[]Spaces following commas
Mark all stan code with ```stan
Unify format of if/for/while loops to always use {} for clarity
Some of these changes were done automatically. It's hard to be certain if I caught every outdated example, but I have checked and am reasonable certain all the changes here are valid.
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: