bugfix/issue-16-fvar-spec-quad_form_sym#18
Merged
Conversation
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
Member
There was a problem hiding this comment.
remove the using statement. Unnecessary now that everything is in the same namespace.
added EXPECT_NO_THROW tests to new type instantiations in quad_form_sym test
Contributor
Author
|
@syclik not sure what happened here, fwd/mat/fun/quad_form_test.cpp passes on my machine. |
Member
|
Jenkins, retest this please. |
Contributor
Author
|
@bob-carpenter @syclik this is ready for code review, should be very straightforward. The main file to focus on is: stan/math/fwd/mat/fun/quad_form_sym.hpp |
Member
|
Cool. |
syclik
added a commit
that referenced
this pull request
Aug 3, 2015
…orm_sym Fixes #16. bugfix/issue-16-fvar-spec-quad_form_sym
yizhang-yiz
referenced
this pull request
in yizhang-yiz/math
Feb 27, 2018
This global variable causes unit test building failure (bug #18)
yizhang-yiz
referenced
this pull request
in yizhang-yiz/math
Feb 27, 2018
This global variable causes unit test building failure (bug #18)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Introduces fvar specialization of quad_form_sym
Intended Effect:
Admits higher-order autodiff of quad_form_sym for mixed type arguments (e.g. Matrix<double, -1, -1>, Matrix<fvar, -1, -1>). Allows for fvar instantiation of gaussian_dlm_obs_log.
How to Verify:
./runTests.py test/unit/math/mix/mat/fun/quad_form_test.cpp
./runTests.py test/unit/math/fwd/mat/fun/quad_form_test.cpp
These should fail in the current math branch.
Side Effects:
None.
Documentation:
None.
Reviewer Suggestions:
Anyone