Skip to content

Added arithmetic version of pow (Fixes: #1809) #1810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bob-carpenter merged 12 commits into from
Apr 5, 2020
Merged

Added arithmetic version of pow (Fixes: #1809) #1810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
def2212
Added arithmetic version of pow (Fixes: #1809)
bbbales2 Mar 30, 2020
d539b58
[Jenkins] auto-formatting by clang-format version 6.0.0 (tags/google/…
stan-buildbot Mar 30, 2020
bb9d624
Added std::pow to stan::math namespace to handle arithmetic types (Is…
bbbales2 Mar 31, 2020
2c14a1f
Added some tests to make sure stan::math::pow, pow, and std::pow are …
bbbales2 Mar 31, 2020
ffc706e
Merge branch 'bugfix/1809-pow' of https://github.com/stan-dev/math in…
bbbales2 Mar 31, 2020
42a06c8
Merge commit 'afe318dc8eb7cfef08509fb8ce16dcf94e3a0ab9' into HEAD
yashikno Mar 31, 2020
5c69da8
[Jenkins] auto-formatting by clang-format version 6.0.0 (tags/google/…
stan-buildbot Mar 31, 2020
b92f149
NOLINT for using namespace tests for pow
Mar 31, 2020
90e3f8f
Added more tests for the arithmetic behavior of stan::math::pow (Issu…
bbbales2 Apr 1, 2020
eb97a64
Don't include using std::pow in stan::math namespace just yet (Issue …
bbbales2 Apr 3, 2020
fce5a54
Merge branch 'bugfix/1809-pow' of https://github.com/stan-dev/math in…
bbbales2 Apr 3, 2020
087a584
Fixed namespace issues in pow tests in mix (Issue #1809)
bbbales2 Apr 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stan/math/opencl/kernel_generator/load.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ class load_
* Creates a deep copy of this expression.
* @return copy of \c *this
*/
inline load_<T&> deep_copy() const & { return load_<T&>(a_); }
inline load_<T&> deep_copy() const& { return load_<T&>(a_); }

@bob-carpenter bob-carpenter Apr 4, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a stray change that shouldn't be in this PR.

@bbbales2 bbbales2 Apr 4, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was the autoformatter, but I dunno why it looked at this file.

@bbbales2 bbbales2 Apr 5, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the commit: d539b58#diff-e92a842ba1a127d7587a635913cb4ce3 . Since this is the autoformatter I'm not going to bother with trying to revert it. Presumably it'd just put it back again.

@rok-cesnovar rok-cesnovar Apr 5, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is related to #1822

The styling on develop was forced by an older version of clang-format. So one PR would eventually have to fix it.

inline load_<T> deep_copy() && { return load_<T>(std::forward<T>(a_)); }

/**
Expand Down
18 changes: 0 additions & 18 deletions stan/math/prim/fun/pow.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,24 +9,6 @@
namespace stan {
namespace math {

// This overload is required becuase MINGW32 does not include the
// specialization std::pow(double, int) as required by the C++11
// standard library interface specification. Use with other compilers
// than MINGW32 would introduce an ambiguity with the standard library.
#if __MINGW32__
/**
* Return the first argument raised to the power of the second
* argument.
*
* @param x base
* @param y exponent
* @return base raised to the power of the exponent
*/
inline double pow(double x, int y) {
return std::pow(x, static_cast<double>(y));
}
#endif

namespace internal {

/**
Expand Down
4 changes: 2 additions & 2 deletions test/unit/math/mix/fun/pow_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ TEST(mathMixScalFun, powInstantiations) {

TEST(mathMixScalFun, pow) {
auto f = [](const auto& x1, const auto& x2) {
using std::pow;
using stan::math::pow;
using std::pow;
return pow(x1, x2);
};
stan::test::expect_ad(f, -0.4, 0.5);
Expand All @@ -57,8 +57,8 @@ TEST(mathMixScalFun, pow) {
}
TEST(mathMixFun, complexPow) {
auto f = [](const auto& x1, const auto& x2) {
using std::pow;
using stan::math::pow;
using std::pow;
return pow(x1, x2);
};
stan::test::ad_tolerances tols;
Expand Down