Feature/issue 123 complex numbers with vars - #789

Closed

ChrisChiasson wants to merge 141 commits into

stan-dev:developfrom

ChrisChiasson:feature/issue-123-complex-numbers-with-vars

Commits on Jul 25, 2018

Failing test for issue 123

Chris Chiasson
authored and
ChrisChiasson
committed
Updated test to use AVAR macro

Chris Chiasson
authored and
ChrisChiasson
committed
Complex numbers rough first attempt

Chris Chiasson
authored and
ChrisChiasson
committed
Fixed accidental reversal of tests

Chris Chiasson
authored and
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 5.0.1 (tags/RELEASE_501/final)

stan-buildbot
authored and
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 6.0.0 (tags/google/stable/2017-11-14)

stan-buildbot
authored and
ChrisChiasson
committed
Changed restriction on stan::math::internal::complex converting ctor to eliminate forward declaration of var or fvar. Tried to fix formatting.

Chris Chiasson
authored and
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 5.0.1-svn319952-1~exp1 (branches/release_50)

stan-buildbot
authored and
ChrisChiasson
committed
Added std::complex<fvar<T>>

Chris Chiasson
authored and
ChrisChiasson
committed
Changes to enable computation with Eigen

Chris Chiasson
authored and
ChrisChiasson
committed
Adding complex double times var

Chris Chiasson
authored and
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 5.0.1 (tags/RELEASE_501/final)

stan-buildbot
authored and
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 6.0.0 (tags/google/stable/2017-11-14)

stan-buildbot
authored and
ChrisChiasson
committed
fixes for fullPivLu() test case

Chris Chiasson
authored and
ChrisChiasson
committed
switched to output std::complex, added hessian test, added static asserts for Eigen and apply_scalar_unary
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 6.0.0 (tags/google/stable/2017-11-14)

stan-buildbot
authored and
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 6.0.0 (tags/google/stable/2017-11-14)

stan-buildbot
authored and
ChrisChiasson
committed
removed inline from type trait value convenience booleans
ChrisChiasson
committed
tried to address cpplint issues
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 6.0.0 (tags/google/stable/2017-11-14)

stan-buildbot
authored and
ChrisChiasson
committed
removed dead code and obviated comments
ChrisChiasson
committed
changed forward declaration keyword for complex to match struct declaration; changed is_same_v to is_same::value
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 6.0.0 (tags/google/stable/2017-11-14)

stan-buildbot
authored and
ChrisChiasson
committed
Trying to change the number of template parameters specified by stan's specialization of Eigen's ScalarBinaryOpTraits to avoid problems on old compilers
ChrisChiasson
committed
remove leftover diff output from merge
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 6.0.0 (tags/google/stable/2017-11-14)

stan-buildbot
authored and
ChrisChiasson
committed
removed compatibility attempt, added include
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 6.0.0 (tags/google/stable/2017-11-14)

stan-buildbot
authored and
ChrisChiasson
committed
removed constexpr from _v template using declarations due to old GCC compiler bugs, changed one of the fvar ctors with boost::enable_if_c as a dummy argument to use std::enable_if_t in the template…
ChrisChiasson
committed
reintroduced equality and inequality
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 5.0.2-svn328729-1~exp1~20180406212027.91 (branches/release_50)

stan-buildbot
authored and
ChrisChiasson
committed
moved enable_if into function parameter list... not sure why this fixes the problem
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 6.0.0 (tags/google/stable/2017-11-14)

stan-buildbot
authored and
ChrisChiasson
committed
removed value template variables because gcc 4.9 doesn't support them, switched fvar copy ctor back into template because one of the tests fails with it in the ctor... I am sure that I will re-lear…
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 6.0.0 (tags/google/stable/2017-11-14)

stan-buildbot
authored and
ChrisChiasson
committed
override clang's complex division, and modify fvar enable_if ctor to not trigger void* = 0 failure
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 6.0.0 (tags/google/stable/2017-11-14)

stan-buildbot
authored and
ChrisChiasson
committed
cpplint
ChrisChiasson
committed
doxygen complaint, headers complaint
ChrisChiasson
committed
duplicate symbol complaint
ChrisChiasson
committed
trying to put code in a state where others can help
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 6.0.0 (tags/google/stable/2017-11-14)

stan-buildbot
authored and
ChrisChiasson
committed
switched back to clang 5 and ported my tests backs to regular cpp files
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 6.0.0 (tags/google/stable/2017-11-14)

stan-buildbot
authored and
ChrisChiasson
committed
trying to use full (explicit) function template specialization to override clang's division
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 6.0.0 (tags/google/stable/2017-11-14)

stan-buildbot
authored and
ChrisChiasson
committed
variable ctor restrictions
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 5.0.2-svn328729-1~exp1~20180406212027.91 (branches/release_50)

stan-buildbot
authored and
ChrisChiasson
committed
moved some operators and classes to their own namespace and tightened some of the SFINAE logic
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 5.0.1 (tags/RELEASE_501/final)

stan-buildbot
authored and
ChrisChiasson
committed
cpplint, stronger types for division override
ChrisChiasson
committed
thought I removed these static_asserts earlier
ChrisChiasson
committed
may have found a method that actually allows the overload... plus more adl fixes
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 5.0.1 (tags/RELEASE_501/final)

stan-buildbot
authored and
ChrisChiasson
committed
reduce derivative operations in denominator & make it squared
ChrisChiasson
committed
Initial attempt to make complex fit stan's structure and pull in updates from develop
ChrisChiasson
committed
Properly hooked into the new non-deducible template argument only version complex_promote
ChrisChiasson
committed
val enable_if_t to make two ambiguous cases exclusive; is_arith_like fixed to not always be true
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 6.0.0 (tags/google/stable/2017-11-14)

stan-buildbot
authored and
ChrisChiasson
committed
trying to get val recursion scheme correct
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 5.0.1 (tags/RELEASE_501/final)

stan-buildbot
authored and
ChrisChiasson
committed
fixup tests
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 6.0.0 (tags/google/stable/2017-11-14)

stan-buildbot
authored and
ChrisChiasson
committed
trying to fix doxygen complaint
ChrisChiasson
committed
made test use double
ChrisChiasson
committed
bring std::sqrt into scope
ChrisChiasson
committed
bringing std::sqrt into scope
ChrisChiasson
committed
hopefully making this a regular comment will make doxygen happy
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 6.0.0 (tags/google/stable/2017-11-14)

stan-buildbot
authored and
ChrisChiasson
committed
go home Doxygen, you're drunk
ChrisChiasson
committed
rm_zeroing doxygen, probably unrelated to Jenkins doxygen error in other file
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 6.0.0 (tags/google/stable/2017-11-14)

stan-buildbot
authored and
ChrisChiasson
committed
using a different doxygen ignore command; it is possible stan doesn't use Doxygen's preprocessor commands for ignores
ChrisChiasson
committed
opened up copysign template some more
ChrisChiasson
committed
added GPU checks

rok-cesnovar
authored and
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 6.0.0 (tags/google/stable/2017-11-14)

stan-buildbot
authored and
ChrisChiasson
committed
Fix docs

SteveBronder
authored and
ChrisChiasson
committed
update docs

SteveBronder
authored and
ChrisChiasson
committed
Adds <code>matrix_gpu<\code> to the docs and moved around the flags and if statements to throw to be within the if statement

SteveBronder
authored and
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 6.0.0 (tags/google/stable/2017-11-14)

stan-buildbot
authored and
ChrisChiasson
committed
remove 0 by 0 being accepted info from docs

SteveBronder
authored and
ChrisChiasson
committed
cpplint error

SteveBronder
authored and
ChrisChiasson
committed
added quotation to BOOST_LIB_ABS

rok-cesnovar
authored and
ChrisChiasson
committed
split gpu checks in to separate files, fixed the header guards, added tests for check diagonal zeros

rok-cesnovar
authored and
ChrisChiasson
committed
change kernel names to is_*

rok-cesnovar
authored and
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 6.0.0 (tags/google/stable/2017-11-14)

stan-buildbot
authored and
ChrisChiasson
committed
add exp() test

bgoodri
authored and
ChrisChiasson
committed
add abs() test

bgoodri
authored and
ChrisChiasson
committed
add arg() test

bgoodri
authored and
ChrisChiasson
committed
add a bunch of tests

bgoodri
authored and
ChrisChiasson
committed
fix acosh_test.cpp

bgoodri
authored and
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 6.0.0 (tags/google/stable/2017-11-14)

stan-buildbot
authored and
ChrisChiasson
committed
trying to improve complex subfunctions and bring in more flexibility for power operations on complex types
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 5.0.1 (tags/RELEASE_501/final)

stan-buildbot
authored and
ChrisChiasson
committed
forgot to add new files to scal.hpp
ChrisChiasson
committed
trying to find a definition of pow that will work on libc++
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 5.0.2-svn328729-1~exp1~20180406212027.91 (branches/release_50)

stan-buildbot
authored and
ChrisChiasson
committed
add pseudo_eigendecomposition_test.cpp

bgoodri
authored and
ChrisChiasson
committed
fix frechet_lccdf test
ChrisChiasson
committed
trying to fix polar and pow... not having a very good time
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 5.0.2-svn328729-1~exp1~20180406212027.91 (branches/release_50)

stan-buildbot
authored and
ChrisChiasson
committed
use std::pow in frechet_lpdf

bgoodri
authored and
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 5.0.2-svn328729-1~exp1~20180406212027.91 (branches/release_50)

stan-buildbot
authored and
ChrisChiasson
committed
use std::pow in frechet_lcdf

bgoodri
authored and
ChrisChiasson
committed
use std::pow in frechet_cdf

bgoodri
authored and
ChrisChiasson
committed
use std::pow in weibull_lpdf

bgoodri
authored and
ChrisChiasson
committed
use std::pow in weibull_cdf

bgoodri
authored and
ChrisChiasson
committed
use std::pow in weibull_lcdf

bgoodri
authored and
ChrisChiasson
committed
use std::pow in weibull_lccdf

bgoodri
authored and
ChrisChiasson
committed
use std::pow in pareto_type_2_cdf

bgoodri
authored and
ChrisChiasson
committed
use std::pow in pareto_type_2_lcdf

bgoodri
authored and
ChrisChiasson
committed
also test imaginary parts are zero

bgoodri
authored and
ChrisChiasson
committed
remove old var ctors taking complex, and remove the complex header, which stops old clang compilers from complaining about std::polar
ChrisChiasson
committed
added more description to zeroing, and removed single level upcast that won't be used
ChrisChiasson
committed
removed the tests added in PR #643 regarding var(std::complex<T>&) using real-only components
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 6.0.0 (tags/google/stable/2017-11-14)

stan-buildbot
authored and
ChrisChiasson
committed
removing test that invokes gcc 4.9's complex bug
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 5.0.2-svn328729-1~exp1~20180406212027.91 (branches/release_50)

stan-buildbot
authored and
ChrisChiasson
committed
Disable complex exp test on gcc < 5 due to compiler bug. See comments on PR #789. Also attempt to fix what may be a javadoc autobrief problem with rm_zeroing that causes the jenkins build to stop
ChrisChiasson
committed
fix pow() and exp() on g++-4.9

bgoodri
authored and
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 6.0.0 (tags/google/stable/2017-11-14)

stan-buildbot
authored and
ChrisChiasson
committed
fix doxygen error

bgoodri
authored and
ChrisChiasson
committed
attempt at abs overloads
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 5.0.1 (tags/RELEASE_501/final)

stan-buildbot
authored and
ChrisChiasson
committed
fix return type on abs functions (whoops)

Chris Chiasson
authored and
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 5.0.1 (tags/RELEASE_501/final)

stan-buildbot
authored and
ChrisChiasson
committed
changes to instantiation -- honestly forgot it *wasn't* being done this way
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 6.0.0 (tags/google/stable/2017-11-14)

stan-buildbot
authored and
ChrisChiasson
committed
attempt at fixing proj on gcc

Chris Chiasson
authored and
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 6.0.0 (tags/google/stable/2017-11-14)

stan-buildbot
authored and
ChrisChiasson
committed
attempt to feed pow the right type in operator_division

Chris Chiasson
authored and
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 6.0.0-1ubuntu2 (tags/RELEASE_600/final)

stan-buildbot
authored and
ChrisChiasson
committed
trying a different approach for operator division... I think I attempted this before, though

Chris Chiasson
authored and
ChrisChiasson
committed
[Jenkins] auto-formatting by clang-format version 5.0.1 (tags/RELEASE_501/final)

stan-buildbot
authored and
ChrisChiasson
committed
just a hunch about the mac push back issue
ChrisChiasson
committed
undoing change to fvar on previous commit -- which is not technically a revert since I'm not rewriting the history

Chris Chiasson
authored and
ChrisChiasson
committed
the special tightly scoped abs(complex) overloads to get around buggy behavior in libstdc++'s complex need a hypot definition available when those same overloads are processed on clang with libc++
ChrisChiasson
committed
in rev/core.hpp, std_numeric_limits appears after std_is_inf, but with the forward of the unprefixed ADL-looked-up is infinity call to the std version, numeric limits of the argument type gets chec…
ChrisChiasson
committed

Commits on Jul 26, 2018

increase tolerance per discussion in PR #789 about this test
ChrisChiasson
authored
increase tolerance because of test failure, similar to the pseudo eigendecomposition test
ChrisChiasson
authored
add using std::pow to normal_sufficient_lpdf.hpp
ChrisChiasson
authored

Uh oh!

Uh oh!

Commits

Commits on Jul 25, 2018

Commits on Jul 26, 2018