Pareto k tail fix#351
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #351 +/- ##
==========================================
- Coverage 95.31% 95.29% -0.02%
==========================================
Files 50 50
Lines 3840 3845 +5
==========================================
+ Hits 3660 3664 +4
- Misses 180 181 +1 ☔ View full report in Codecov by Sentry. |
Collaborator
|
Looks sensible to me. Any more changes you want to do before I merge? |
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 8435f4a is merged into master:
|
Collaborator
Author
|
I don't have more to add regarding this, you can merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As brought up by @avehtari in issue #345, when one tail is constant, but
tail = "both"is specified, it is better to return the diagnostic for the non-constant tail rather thanNA.Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: