Skip to content

type check assertions for rvar draws, closes #363#364

Merged
mjskay merged 1 commit into
masterfrom
rvar-type-check
May 7, 2024
Merged

type check assertions for rvar draws, closes #363#364
mjskay merged 1 commit into
masterfrom
rvar-type-check

Conversation

@mjskay
Copy link
Copy Markdown
Collaborator

@mjskay mjskay commented May 7, 2024

Summary

Adds assertions to prevent draws of invalid types being used in an rvar. Closes #363.

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@paul-buerkner
Copy link
Copy Markdown
Collaborator

thanks! feel free to merge as you please

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2024

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 609028d is merged into master:

  • ✔️as_draws_array: 142ms -> 143ms [-0.61%, +1.01%]
  • ✔️as_draws_df: 68.2ms -> 68.8ms [-0.58%, +2.33%]
  • 🚀as_draws_list: 165ms -> 163ms [-2.28%, -1.12%]
  • ❗🐌as_draws_matrix: 65.1ms -> 66.1ms [+0.54%, +2.72%]
  • 🚀as_draws_rvars: 84.9ms -> 83.1ms [-3.57%, -0.79%]
  • 🚀summarise_draws_100_variables: 743ms -> 705ms [-5.48%, -4.86%]
  • ❗🐌summarise_draws_10_variables: 113ms -> 115ms [+0.63%, +2.16%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@mjskay mjskay merged commit fd72161 into master May 7, 2024
@mjskay mjskay deleted the rvar-type-check branch May 7, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Errors when rvar is made from a data frame

2 participants