Skip to content

Relocate stan/lang/rethrow_located.hpp - #2917

Closed
rok-cesnovar wants to merge 5 commits into
developfrom
relocate_rethrow_located
Closed

Relocate stan/lang/rethrow_located.hpp#2917
rok-cesnovar wants to merge 5 commits into
developfrom
relocate_rethrow_located

Conversation

@rok-cesnovar

@rok-cesnovar rok-cesnovar commented May 8, 2020

Copy link
Copy Markdown
Member

Submission Checklist

  • Run unit tests: ./runTests.py src/test/unit
  • Run cpplint: make cpplint
  • Declare copyright holder and open-source license: see below

Summary

Fixes one part of #1448 by relocating relocate_rethrow to /model.

This is the first PR where we move the rethrow_located file and change the namespace but still keep a duplicate in the original namespace.

This is so the tests will pass, we can then update stanc3 to use the new namespace and then remove the duplicates.

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Rok Češnovar

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@stan-buildbot

Copy link
Copy Markdown
Contributor

Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan 5.15 5.07 1.02 1.49% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 1.0 -0.07% slower
eight_schools/eight_schools.stan 0.1 0.09 1.07 6.33% faster
gp_regr/gp_regr.stan 0.23 0.23 0.99 -0.66% slower
irt_2pl/irt_2pl.stan 6.47 6.44 1.0 0.44% faster
performance.compilation 85.69 84.49 1.01 1.41% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 8.02 7.64 1.05 4.8% faster
pkpd/one_comp_mm_elim_abs.stan 20.27 20.95 0.97 -3.39% slower
sir/sir.stan 93.07 91.82 1.01 1.34% faster
gp_regr/gen_gp_data.stan 0.05 0.05 0.99 -0.95% slower
low_dim_gauss_mix/low_dim_gauss_mix.stan 2.98 2.97 1.0 0.48% faster
pkpd/sim_one_comp_mm_elim_abs.stan 0.31 0.33 0.95 -5.26% slower
arK/arK.stan 1.74 1.74 1.0 -0.07% slower
arma/arma.stan 0.77 0.78 0.99 -0.85% slower
garch/garch.stan 0.57 0.61 0.94 -6.74% slower
Mean result: 0.999879394177

Jenkins Console Log
Blue Ocean
Commit hash: 9a1b01d


Machine information ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

@rok-cesnovar

Copy link
Copy Markdown
Member Author

Closing, will address this once we decide to remove stanc2. The location of this file will need to be coordinate with rstan.

@rok-cesnovar
rok-cesnovar deleted the relocate_rethrow_located branch January 28, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants