Skip to content

Point Jenkins back to main docker images - #1036

Merged
serban-nicusor-toptal merged 2 commits into
masterfrom
docker-rename
Nov 16, 2021
Merged

Point Jenkins back to main docker images#1036
serban-nicusor-toptal merged 2 commits into
masterfrom
docker-rename

Conversation

@WardBrian

Copy link
Copy Markdown
Member

Submission Checklist

  • Run unit tests

Release notes

Following #1019, we have Jenkins using images like stanorg/stanc3:static-ocaml-update. @serban-nicusor-toptal is going to rename those back to the standard names (without -ocaml-update) now that it is merged, and this will go along with that.

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)

@rok-cesnovar

Copy link
Copy Markdown
Member

This might just be noise and you are aware of it, so forgive me if that is the case, the master run failed: https://jenkins.mc-stan.org/blue/organizations/jenkins/stanc3/detail/master/966/pipeline

@WardBrian

Copy link
Copy Markdown
Member Author

Yeah, luckily it failed at the internal documentation stage (e.g, nothing really bad). @serban-nicusor-toptal is on it, it is a permissions issue with that last step.

@serban-nicusor-toptal

serban-nicusor-toptal commented Nov 16, 2021

Copy link
Copy Markdown
Contributor

Hey, above issue should be fixed now. When we've switched to 4.12 docker image, it comes pre-bundled with the opam groups we were creating and for some reason it didn't like UID/GID 1000 because on our VM that isn't opam.
I'm now waiting for the Jenkins job to finish with the docker images.

@WardBrian
WardBrian marked this pull request as ready for review November 16, 2021 18:58

@serban-nicusor-toptal serban-nicusor-toptal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serban-nicusor-toptal
serban-nicusor-toptal merged commit 109a3ac into master Nov 16, 2021
@WardBrian
WardBrian deleted the docker-rename branch November 16, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants