Add require_* templates to generated functions - #1106
Merged
Conversation
rok-cesnovar
approved these changes
Feb 1, 2022
rok-cesnovar
left a comment
rok-cesnovar
left a comment
Member
There was a problem hiding this comment.
Looks good to me. Merge assuming tests pass. If @SteveBronder has time to have a look in the next day or two, I wouldn't mind him taking a quick peek at this for a sanity check.
I think an RC2 is in line with this as well.
Thanks for jumping on this so quick!
Member
Author
|
@SteveBronder messaged me to say he can take a look later, which I'd also appreciate (never can be too careful around these templates) |
SteveBronder
approved these changes
Feb 1, 2022
SteveBronder
left a comment
SteveBronder
left a comment
Contributor
There was a problem hiding this comment.
Looks good! There's a few cleanups I'd like to do in the codegen but nothing that's a blocker so those can wait till after the release
Member
|
One thing that I thought of now. What about if some args are varmat? Or do we not handle varmats with udfs? |
Contributor
|
^not supported yet so all good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Release notes
Closes #1105 by adding
require_*templates to the code generated by user-defined functions.Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)