Skip to content

Clean up module interfaces - #1179

Merged
WardBrian merged 5 commits into
masterfrom
module-cleanup
Apr 26, 2022
Merged

Clean up module interfaces#1179
WardBrian merged 5 commits into
masterfrom
module-cleanup

Conversation

@WardBrian

@WardBrian WardBrian commented Apr 26, 2022

Copy link
Copy Markdown
Member

This does a few things:

  1. Closes .mli file usage #358 by deleting the 'index' modules which dune creates for us, like Middle.ml
  2. Adds interfaces and documentation for a couple more existing modules, namely Canonicalize and Stan_math_signatures
  3. Removes Frontend_utils by finding better homes for what lived there (basically all of it's functions were only called in one place and not generalizable)

Submission Checklist

  • Run unit tests
  • Documentation
    • OR, no user-facing changes were made

Release notes

Cleaned up the internal structuring of modules in the compiler

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)

@WardBrian WardBrian added the cleanup Code simplification or clean-up label Apr 26, 2022

@rok-cesnovar rok-cesnovar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@WardBrian
WardBrian merged commit c0e01d4 into master Apr 26, 2022
@WardBrian
WardBrian deleted the module-cleanup branch April 26, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Code simplification or clean-up

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.mli file usage

2 participants