Handle leading zeros in scientific notation literals#1336
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1336 +/- ##
=======================================
Coverage 88.77% 88.77%
=======================================
Files 64 64
Lines 9873 9873
=======================================
Hits 8765 8765
Misses 1108 1108
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm performing some fuzzing for #1100 and it found this bug which exists independently of that PR. The AST to MIR translation currently avoids trimming a leading zero if the next character is
eor., but notE, leading to (in this case) failures in the partial evaluator at--O1.Submission Checklist
Release notes
Fixed an issue with leading zeroes in real literals like
0E0Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)