-
-
Notifications
You must be signed in to change notification settings - Fork 54
Compiler support for laplace_latent_solve(_tol)
#1649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
florence-bockting
wants to merge
8
commits into
stan-dev:master
Choose a base branch
from
florence-bockting:laplace/return-cov-chol
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4b60683
feat: add laplace_latent_solve(_tol) to signatures and update Typeche…
ccd9f1c
tests: update test and reference file to include laplace_latent_solve…
9f2814e
tests: add bad pathway tests and update stanc.expected
6e2c28b
fix: run formatter
ec9a2f8
fix: ensure laplace_latent_solve is called in generated quantities block
0d1bb6d
fix: update Typechecker; laplace_latent_solve only allowed in GQ block
7301b80
fix: Ocaml formatting
641c70b
tests: delete weak bad test
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
test/integration/bad/embedded_laplace/bad_solve_model.stan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| functions { | ||
| // specify negative binomial likelihood with mean offset | ||
| real ll_function(vector theta, // latent Gaussian | ||
| real eta, vector log_ye, // mean offset | ||
| array[] int y) { | ||
| // observed count | ||
| return neg_binomial_2_lpmf(y | exp(log_ye + theta), eta); | ||
| } | ||
|
|
||
| // specify covariance function | ||
| matrix K_function(array[] vector x, int n_obs, real alpha, real rho) { | ||
| matrix[n_obs, n_obs] K = gp_exp_quad_cov(x, alpha, rho); | ||
| for (i in 1 : n_obs) | ||
| K[i, i] += 1e-8; | ||
| return K; | ||
| } | ||
| } | ||
| data { | ||
| int n_obs; | ||
| int n_coordinates; | ||
| array[n_obs] int y; | ||
| vector[n_obs] ye; | ||
| array[n_obs] vector[n_coordinates] x; | ||
| } | ||
|
|
||
| transformed data { | ||
| vector[n_obs] log_ye = log(ye); | ||
| } | ||
| parameters { | ||
| real<lower=0> alpha; | ||
| real<lower=0> rho; | ||
| real<lower=0> eta; | ||
| } | ||
|
|
||
| model { | ||
| // laplace_latent_solve is only callable in Generated Quantities block | ||
| tuple(vector[n_obs], matrix[n_obs, n_obs]) mean_chol | ||
| = laplace_latent_solve(ll_function, (eta, log_ye, y), 1, | ||
| K_function, (x, n_obs, alpha, rho)); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| functions { | ||
| // specify negative binomial likelihood with mean offset | ||
| real ll_function(vector theta, // latent Gaussian | ||
| real eta, vector log_ye, // mean offset | ||
| array[] int y) { | ||
| // observed count | ||
| return neg_binomial_2_lpmf(y | exp(log_ye + theta), eta); | ||
| } | ||
|
|
||
| // specify covariance function | ||
| matrix K_function(array[] vector x, int n_obs, real alpha, real rho) { | ||
| matrix[n_obs, n_obs] K = gp_exp_quad_cov(x, alpha, rho); | ||
| for (i in 1 : n_obs) | ||
| K[i, i] += 1e-8; | ||
| return K; | ||
| } | ||
| } | ||
| data { | ||
| int n_obs; | ||
| int n_coordinates; | ||
| array[n_obs] int y; | ||
| vector[n_obs] ye; | ||
| array[n_obs] vector[n_coordinates] x; | ||
| } | ||
|
|
||
| transformed data { | ||
| vector[n_obs] log_ye = log(ye); | ||
| } | ||
| parameters { | ||
| real<lower=0> alpha; | ||
| real<lower=0> rho; | ||
| real<lower=0> eta; | ||
| } | ||
|
|
||
| generated quantities { | ||
| // _tol variant requires a trailing control-parameter tuple | ||
| tuple(vector[n_obs], matrix[n_obs, n_obs]) mean_chol | ||
| = laplace_latent_solve_tol(ll_function, (eta, log_ye, y), 1, K_function, | ||
| (x, n_obs, alpha, rho)); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit unusual, but especially since we think we may one day lift the restriction, I'd prefer to have the cf.current_block check occur here, where we already know we are looking at one of these functions