Use a Dynarray instead of a hashtable for the preprocessor locations - #1650
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1650 +/- ##
=======================================
Coverage 91.51% 91.52%
=======================================
Files 67 67
Lines 9975 9981 +6
=======================================
+ Hits 9129 9135 +6
Misses 846 846
🚀 New features to boost your workflow:
|
nhuurre
reviewed
Jul 28, 2026
Also use stdlib where appropriate
nhuurre
approved these changes
Jul 28, 2026
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hashtable only ever had keys that were numeric and growing, which means it was essentially just a growable array in a language without good support for those. Now that the standard library has a
Dynarraymodule, we can use that and save on some storageSubmission Checklist
Release notes
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)