Stanc.Std: Move over Analysis module - #1661
Conversation
0e4e28a to
60fbb2b
Compare
60fbb2b to
76c1fb4
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## std/stan_math_backend #1661 +/- ##
=========================================================
- Coverage 92.17% 92.12% -0.05%
=========================================================
Files 70 70
Lines 10128 10141 +13
=========================================================
+ Hits 9335 9342 +7
- Misses 793 799 +6
🚀 New features to boost your workflow:
|
| stan::model::assign(psi_con, lcm_sym19__, | ||
| "assigning variable psi_con", stan::model::index_uni(i)); | ||
| stan::model::assign(psi_con, 1, "assigning variable psi_con", | ||
| stan::model::index_uni(i)); |
There was a problem hiding this comment.
Looks like constant propagation got a bit smarter, but why?
There was a problem hiding this comment.
I spent a few hours on trying to debug this and I couldn’t pinpoint the change.
I also threw whatever free credits of Claude github gives me, and it spun in circles but couldn’t identify anything either after spending the entire month’s allocation.
In the end, I think the fact that this wasn’t being propagated in master was a bug, and the relevant optimizations are only turned on for Oexperimental, so I gave up looking for the cause… if you can find anything without wasting too much time, I would still be curious!
The most notable change here is the addition of our own vendored polymorphic set. This is based on OCaml's set implementation, but with polymorphic comparison swapped in. Remarkably, I've found that it is dramatically faster than Base.Set.Poly in our uses, presumably because
Base.Set.Polyis storing the comparison function in the runtime representation still, even though it never changesSubmission Checklist
Release notes
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)
Stack created with GitHub Stacks CLI • Give Feedback 💬