Changed the MIR to represent function declarations as Options - #539
Merged
Conversation
Collaborator
|
Sorry, I should've reviewed this a month ago. Could you resolve the merge conflicts? This certainly improves the MIR. |
Collaborator
Author
|
No worries, thanks, I'll add this to my to do list. |
Collaborator
|
Thanks. Is this waiting for #627 or did you forget to |
Collaborator
Author
|
Ha yeah you caught me - I was waiting for #627 because I had trouble installing ocamlformat 0.8 because it's quite old. |
nhuurre
approved these changes
Sep 15, 2020
nhuurre
left a comment
nhuurre
left a comment
Collaborator
There was a problem hiding this comment.
Just needs a dune promote.
Member
|
Bumping this. @rybern do you have a few minutes to merge master in and run dune promote so we can merge this. |
Collaborator
Author
|
Ah, thanks Rok! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #538
The large diffs in the expect tests are because adding an option type adds a set of parenthesis to the SExp