Allow scale to compose with transformations#971
Closed
WardBrian wants to merge 9 commits into
Closed
Conversation
Member
Author
|
@SteveBronder - This is the proof of concept of the alternative version. If you ignore the multiarch build problem ATM it compiles all the models fine, including the following: data {
int<lower=0> N;
}
parameters {
array[3] real<lower=0><offset=10> loweroffset;
real<lower=0, upper=1><offset=1, multiplier=10> allfour;
simplex<offset=1>[10] offset_simplex;
positive_ordered<multiplier=10>[N] multiplied_ordered;
}We can throw this into cmdstan and start doing some actual modeling tests next week |
Member
Author
|
The implementation here should be good to go, @bob-carpenter and I need to work on some example models and the doc for it. |
Closed
Contributor
|
Is this waiting on review? |
Member
Author
|
There was a lot of discussion in #659 about whether this was the right thing to do or not, which is the bigger blocker I believe |
Member
Author
|
This has fallen too far behind, so I'm going to close it for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a much more limited alternate take on #947. Basically, separate out offset and multiplier from the idea of a transformation, and allow them to be composed, but not arbitrary other compositions. This aligns more directly with #659
Submission Checklist
Release notes
Offset/Multiplier scaling can now be applied to constrained data types, like
real<lower=0><offset=1>. When constraining, the scaling is done first so that the result is truly of the constrained type.Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)