Add multi-window service containers - #383
Open
botoddly wants to merge 1 commit into
Open
Conversation
stanoddly
reviewed
Aug 10, 2026
stanoddly
reviewed
Aug 10, 2026
stanoddly
reviewed
Aug 10, 2026
stanoddly
reviewed
Aug 10, 2026
|
|
||
| namespace GameKit.App; | ||
|
|
||
| internal sealed class RenderScheduler |
Owner
There was a problem hiding this comment.
I feel like the name is strange, it's not schedule per se. It's just executing them in certain order, one by one. It's somehow a render manager of render managers.
Also, Publish and Unpublish sound really odd.
stanoddly
reviewed
Aug 10, 2026
|
|
||
| if (windowId == 0) | ||
| { | ||
| session = null!; |
Owner
There was a problem hiding this comment.
Forcing a non nullable item to be null? Not good.
stanoddly
reviewed
Aug 12, 2026
|
|
||
| <ItemGroup> | ||
| <InternalsVisibleTo Include="GameKit.Tests" /> | ||
| <InternalsVisibleTo Include="GameKit.RenderOrchestration" /> |
stanoddly
reviewed
Aug 12, 2026
| if (title == null) | ||
| { | ||
| using var process = System.Diagnostics.Process.GetCurrentProcess(); | ||
| using System.Diagnostics.Process process = System.Diagnostics.Process.GetCurrentProcess(); |
botoddly
force-pushed
the
multi-window-containers
branch
from
August 13, 2026 06:52
fe8d407 to
a708c34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the first multi-window delivery discussed in #382.
Summary
Window reactivation and secondary-window Pencuil composition remain follow-up work.
Verification
Graphical SDL execution was intentionally not added to the automated suite.