Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/GameKit.RenderOrchestration/DefaultRenderManager.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using GameKit.App;
using GameKit.DependencyInjection;
using GameKit.Gpu;

namespace GameKit.RenderOrchestration;
Expand All @@ -12,16 +13,16 @@ public class DefaultRenderManager<TRenderContext> : IRenderManager
{
private readonly GpuMemorySystem _gpuMemorySystem;
private readonly IRenderContextProvider<TRenderContext> _renderContextProvider;
private readonly RenderPhaseRegistry<TRenderContext> _renderPhaseRegistry;
private readonly ServiceRegistry<IRenderPhase<TRenderContext>> _renderPhases;

internal DefaultRenderManager(
GpuMemorySystem gpuMemorySystem,
IRenderContextProvider<TRenderContext> renderContextProvider,
RenderPhaseRegistry<TRenderContext> renderPhaseRegistry)
ServiceRegistry<IRenderPhase<TRenderContext>> renderPhases)
{
_gpuMemorySystem = gpuMemorySystem;
_renderContextProvider = renderContextProvider;
_renderPhaseRegistry = renderPhaseRegistry;
_renderPhases = renderPhases;
}

/// <summary>
Expand All @@ -36,7 +37,10 @@ public void Execute()

using (renderContext)
{
_renderPhaseRegistry.Render(renderContext);
foreach (IRenderPhase<TRenderContext> renderPhase in _renderPhases)
{
renderPhase.Render(renderContext);
}

// submit all pending changes before renderContext is disposed
_gpuMemorySystem.Submit();
Expand Down
19 changes: 3 additions & 16 deletions src/GameKit.RenderOrchestration/GameKitAppBuilderExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,25 +8,12 @@ public static class GameKitAppBuilderExtensions
{
public static GameKitAppBuilder UseDefaultRenderManager<TRenderContext>(this GameKitAppBuilder builder) where TRenderContext: IRenderContext
{
RenderPhaseRegistry<TRenderContext> renderPhaseRegistry = new();
builder.OnActivated((instance, _) =>
{
if (instance is IRenderPhase<TRenderContext> renderPhase)
{
renderPhaseRegistry.Register(renderPhase);
}
});
builder.OnDisposing((instance, _) =>
{
if (instance is IRenderPhase<TRenderContext> renderPhase)
{
renderPhaseRegistry.Unregister(renderPhase);
}
});
builder.AddRegistry<IRenderPhase<TRenderContext>>(
static (left, right) => left.Order.CompareTo(right.Order));
builder.AddSingleton<IRenderManager>(sp => new DefaultRenderManager<TRenderContext>(
sp.GetRequiredService<GpuMemorySystem>(),
sp.GetRequiredService<IRenderContextProvider<TRenderContext>>(),
renderPhaseRegistry));
sp.GetRequiredService<ServiceRegistry<IRenderPhase<TRenderContext>>>()));
return builder;
}

Expand Down
72 changes: 0 additions & 72 deletions src/GameKit.RenderOrchestration/RenderPhaseRegistry.cs

This file was deleted.

Loading