[persistence] Optimize result parsing in GenericPojoDao::getV2#1804
Merged
anshul98ks123 merged 2 commits intomasterfrom Feb 19, 2025
Merged
[persistence] Optimize result parsing in GenericPojoDao::getV2#1804anshul98ks123 merged 2 commits intomasterfrom
anshul98ks123 merged 2 commits intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cyrilou242
approved these changes
Feb 19, 2025
| final List<E> results = new ArrayList<>(); | ||
| final List<E> results = new ArrayList<>(entities.size()); | ||
| if (CollectionUtils.isNotEmpty(entities)) { | ||
| Class<E> beanClass = (Class<E>) daoFilter.getBeanClass(); |
Contributor
There was a problem hiding this comment.
final here is actually important, it may help the compiler a lot
btw were you able to measure the cost of the casting ? in this case JIT should be able to figure this out
anyway code looks good.
let's have a working session about benchmarking and profiling if you're interested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s)
Investigate and fix anomalies list API slow response
Description
Optimizes parsing logic of query result in getV2 method of GenericPojoDao
Testing