Skip to content

[persistence] Add counter to track invalid namespace configuration state #1807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anshul98ks123 merged 2 commits into from
Apr 11, 2025
Merged

[persistence] Add counter to track invalid namespace configuration state #1807

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a67db0c
[persistence] Add counter to track invalid namespace configuration state
anshul98ks123 Apr 11, 2025
dbc2356
refactor
anshul98ks123 Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...e/src/main/java/ai/startree/thirdeye/datalayer/bao/NamespaceConfigurationManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
import ai.startree.thirdeye.spi.datalayer.dto.TimeConfigurationDTO;
import com.google.inject.Inject;
import com.google.inject.Singleton;
import io.micrometer.core.instrument.Counter;
import io.micrometer.core.instrument.Metrics;
import java.util.List;
import org.checkerframework.checker.nullness.qual.NonNull;
import org.checkerframework.checker.nullness.qual.Nullable;
Expand All @@ -40,13 +42,18 @@ public class NamespaceConfigurationManagerImpl implements NamespaceConfiguration
private final @Nullable TimeConfiguration timeConfiguration;
private final NamespaceConfigurationDTO defaultNamespaceConfiguration;

private final Counter namespaceConfigurationInvalidStateCounter;

@Inject
public NamespaceConfigurationManagerImpl(final NamespaceConfigurationDao dao,
final @Nullable TimeConfiguration timeConfiguration,
final NamespaceConfigurationDTO defaultNamespaceConfiguration) {
this.dao = dao;
this.timeConfiguration = timeConfiguration;
this.defaultNamespaceConfiguration = defaultNamespaceConfiguration;
this.namespaceConfigurationInvalidStateCounter = Counter.builder(
"thirdeye_invalid_namespace_configuration_state_total")
.register(Metrics.globalRegistry);
}

public @NonNull NamespaceConfigurationDTO getNamespaceConfiguration(final String namespace) {
Expand Down Expand Up @@ -137,6 +144,9 @@ private NamespaceConfigurationDTO fetchExistingNamespaceConfiguration(String nam
"namespace", namespace));
final List<NamespaceConfigurationDTO> results = filter(daoFilter);
if (results != null && !results.isEmpty()) {
if (results.size() != 1) {
namespaceConfigurationInvalidStateCounter.increment();
}
checkState(results.size() == 1,
"Invalid state. Multiple namespace configuration exist for namespace %s. Contact support",
namespace);
Expand Down
Loading