Skip to content

Add —without-dependencies option for starter kit installations #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jesseleite merged 2 commits into from
Mar 4, 2022
Merged

Add —without-dependencies option for starter kit installations #49

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c9a552
Add `—without-dependencies` option for starter kit installations.
jesseleite Mar 4, 2022
0cc5806
Refactor `—dev` to use `processArguments()` method.
jesseleite Mar 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Refactor —dev to use processArguments() method.
  • Loading branch information
@jesseleite
jesseleite committed Mar 4, 2022
commit 0cc58069d27b94d17cc25b6b15bf324df8e29b98
18 changes: 6 additions & 12 deletions src/NewCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ class NewCommand extends Command
public $relativePath;
public $absolutePath;
public $name;
public $version;
public $starterKit;
public $starterKitVcs;
public $starterKitLicense;
Expand Down Expand Up @@ -160,6 +161,10 @@ protected function processArguments()

$this->name = pathinfo($this->absolutePath)['basename'];

$this->version = $this->input->getOption('dev')
? 'dev-master'
: '';

$this->starterKit = $this->input->getArgument('starter-kit');
$this->starterKitLicense = $this->input->getOption('license');
$this->local = $this->input->getOption('local');
Expand Down Expand Up @@ -721,11 +726,9 @@ protected function createProjectCommand()

$baseRepo = self::BASE_REPO;

$version = $this->getVersion();

$directory = $this->pathIsCwd() ? '.' : $this->relativePath;

return $composer." create-project {$baseRepo} \"{$directory}\" {$version} --remove-vcs --prefer-dist";
return $composer." create-project {$baseRepo} \"{$directory}\" {$this->version} --remove-vcs --prefer-dist";
}

/**
Expand Down Expand Up @@ -842,13 +845,4 @@ public function __call($method, $args)
}
};
}

protected function getVersion()
{
if ($this->input->getOption('dev')) {
return 'dev-master';
}

return '';
}
}