Allow starter kit installer interactivity#56
Merged
jesseleite merged 3 commits intomasterfrom Oct 6, 2022
Merged
Conversation
…per user on cms end.
…o disable for API scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After releasing statamic/cms#6792, we noticed that
starter-kit:installis run non-interactively, suppressing any user input prompts in a starter kit's post-install hook. This PR fixes this.We're also removing the 'temporary' comment on
--cli-install, because the starter kit installer should never handle the creation of a super user when using this cli installer. It needs to be here anyway, for when installing statamic/statamic without a starter kit.Note: The above-mentioned post-install hook interactivity doesn't work in Windows due to the lack of TTY support in Windows. For these situations, we instead output any cached post-install instructions passed along by statamic/cms...