[6.x] Scope shared static cache errors to sites#14763
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#10294 introduced statically caching 404s when using half measure static caching. Additionally, it introduced a config setting that lets you
share_errorswhich results in a single 404 page being served to all requests that result in a 404. The cache key generated in thefakeStaticCacheStatusrequest is not scoped to any site though but to/__shared-errors/{status}. When using multi-site this leads to whichever site/locale renders an error first "wins". Every site is then served that one site's 404 even when it's the wrong language, for example.The fix is to namespace the cache key for each error page to the respective site.
Single-site installs are unaffected because the handle is just
defaultso the behavior is unchanged.The added test caches a shared error for one site and asserts a second site neither sees it nor has it overwritten as well as checking that each site retrieves its own error page.