Added --border-width option to control added border around image.#73
Open
apnadkarni wants to merge 1 commit intostathissideris:masterfrom
Open
Added --border-width option to control added border around image.#73apnadkarni wants to merge 1 commit intostathissideris:masterfrom
apnadkarni wants to merge 1 commit intostathissideris:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to be able to control the borders (hardcoded to 2 cells) added to the image so I added the --border-width option. The code ensures it is greater than 0 as setting it to 0 breaks the intersection code. There was a comment in the original code about border being hardcoded to 2 to work around some fill artifacts but I couldn't see which cases would cause this if set to 1.
I set version to include "borderwidth" in project.clj to distinguish my build. You probably do not want to pick that up.
Warning: I'm well versed in C and other languages but this is the first time I've touched Java code :-)