Merged
Conversation
Contributor
Author
|
Test failures seem to be unrelated...? |
|
Yep that Levy test has been consistently flaky, shouldn't be a blocker for merge |
Contributor
|
Thanks for the fix @FreezyLemon and the check on the test @nataziel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the errors introduced by #314. These are just the lowest effort way to get it to compile in
no_stdagain, some of the new code can maybe be rewritten to becomeno_std-compatible. This should allowmasterto pass CI again though.