Skip to content

implemented anderson darling test#346

Merged
YeungOnion merged 4 commits intostatrs-dev:masterfrom
DanielLacina:anderson_darling
Jul 12, 2025
Merged

implemented anderson darling test#346
YeungOnion merged 4 commits intostatrs-dev:masterfrom
DanielLacina:anderson_darling

Conversation

@DanielLacina
Copy link
Contributor

No description provided.

@YeungOnion
Copy link
Contributor

Hi there, thanks for the contribution!

But for the one spot I commented, it all looks good to me. Feel free to ask any other questions.

@DanielLacina
Copy link
Contributor Author

@YeungOnion I resolved the issue.

@codecov
Copy link

codecov bot commented Jul 12, 2025

Codecov Report

Attention: Patch coverage is 92.20779% with 6 lines in your changes missing coverage. Please review.

Project coverage is 94.99%. Comparing base (526e85e) to head (5a26c15).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/stats_tests/anderson_darling.rs 92.20% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
- Coverage   95.01%   94.99%   -0.02%     
==========================================
  Files          60       61       +1     
  Lines       13529    13606      +77     
==========================================
+ Hits        12854    12925      +71     
- Misses        675      681       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DanielLacina
Copy link
Contributor Author

I fixed the formatting and added one test to coverage more code.

@YeungOnion
Copy link
Contributor

The clippy error isn't on you, thanks for this!

@YeungOnion YeungOnion merged commit 2a21f02 into statrs-dev:master Jul 12, 2025
6 of 8 checks passed
@DanielLacina DanielLacina deleted the anderson_darling branch July 12, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants