This repository was archived by the owner on Dec 3, 2021. It is now read-only.
Fixes status-im/status-react#1200#5
Open
RNGMonk wants to merge 1 commit into
Open
Conversation
RNGMonk
commented
Jun 8, 2017
| } | ||
| // Intercept target=_blank and other links that want to open in a new window | ||
| // and deal with them in the WebView if possible | ||
| else if (!navigationAction.targetFrame) { |
Author
There was a problem hiding this comment.
Here's the actual fix, apologies for all the whitespace trimming noise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes status-im/status-legacy#1200
Summary:
Anna found that some pages (e.g. results page on google.ru) would open in Safari instead of the WebView on iOS. The cause of this was that results on google.ru have the target="_blank" attribute and WKWebView default behaviour is to open this in Safari which is a change from UIWebView.
I added an additional test case in
decidePolicyForNavigationActionwhich intercepts requests opening in a new frame and attempts to handle it in the webview instead.Steps to test:
react-native-webview-bridgedependency in package.json togithub:occamin/react-native-webview-bridge#bug/page-opened-in-browser-instead-of-webview-#1200, clean and rebuild.status: ready