Skip to content

docs: fix heading and disable lint rule#11840

Merged
kgryte merged 4 commits intodevelopfrom
philipp/fix-commit-review-2026-04-29
May 2, 2026
Merged

docs: fix heading and disable lint rule#11840
kgryte merged 4 commits intodevelopfrom
philipp/fix-commit-review-2026-04-29

Conversation

@Planeshifter
Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

  • Follow-up fixes for commits merged to develop between 2026-04-28 18:13 and 2026-04-29 09:22 (16 commits, range bb1eae9b..ba7a1573c).

Validated, high-signal issues found and fixed:

  • ndarray/base/reinterpret-complex — Fix heading in lib/node_modules/@stdlib/ndarray/base/reinterpret-complex/README.md (introduced in 2eb9120): changed # reinterpret to # reinterpretComplex to match the convention used by sibling packages (reinterpret-complex128, reinterpret-complex64, reinterpret-boolean).
  • docs/talks.md — In 59a6ae8 (docs/talks.md), the HPSF Conference 2026 <img> tag had an empty src, leaving the thumbnail broken despite the PNG being committed alongside it; patched to use the jsDelivr CDN URL pinned to that commit, consistent with every other entry in the file.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation

Audited every commit merged to develop in the last 24 hours via four parallel reviewers (two stdlib-style passes, two correctness passes). Each reviewer's findings were cross-checked against the diff before being accepted.

Checked:

  • stdlib code style compliance (compared new packages against established sibling packages: dcartesian-square for scartesian-square; reinterpret-complex128/reinterpret-complex64/reinterpret-boolean for reinterpret-complex).
  • Correctness/bug scan over the diff (copy-paste mismatches, type/precision mistakes, broken examples, off-by-one).

Deliberately excluded:

  • Subjective preferences and "suggestions".
  • Issues requiring context outside the diff window to validate.
  • Auto-generated REPL data, stdlib-bot TS declaration syncs, and the deliberate node/n/ ESLint plugin rename (all listed on the reviewers' guard list).

One class of false positive was filtered out and is worth recording: two reviewers flagged the @example outputs in ndarray/base/reinterpret-complex (README, lib/main.js, docs/types/index.d.ts) as wrong, claiming zeroTo([2,2], { dtype: 'complex128' }) should produce sequential 0,1,2,3 across the whole ndarray. By default zeroTo fills along the last dimension only (dims: [-1]), so the duplicated-row output as documented is correct.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was authored by Claude Code as part of a routine cross-commit review of the last 24 hours of merges to develop. Each fix was independently re-verified by re-reading the originating diff and the relevant style convention before being applied.


@stdlib-js/reviewers


Generated by Claude Code

claude added 3 commits April 29, 2026 12:23
Match the camelCase function name `reinterpretComplex`, consistent with sibling packages (`reinterpret-complex128`, `reinterpret-complex64`, `reinterpret-boolean`).
Pin to the jsDelivr CDN path that includes the committed asset, matching the convention used by every other entry in `docs/talks.md`.
Top-level docs page does not expose `usage`/`examples` sections; mirror the directive used by `docs/contributing/zen_of_stdlib.md`.
@Planeshifter Planeshifter marked this pull request as ready for review April 30, 2026 01:29
@Planeshifter Planeshifter requested a review from a team April 30, 2026 01:29
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Apr 30, 2026
@Planeshifter Planeshifter changed the title docs: follow-up fixes for commits merged to develop on 2026-04-28..29 chore: populate image src and update heading Apr 30, 2026
@Planeshifter Planeshifter requested a review from kgryte April 30, 2026 01:30
@kgryte
Copy link
Copy Markdown
Member

kgryte commented May 1, 2026

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label May 1, 2026
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label May 1, 2026
@kgryte kgryte changed the title chore: populate image src and update heading docs: fix heading and disable lint rule May 1, 2026
@kgryte kgryte added Documentation Improvements, additions, or changes to documentation. and removed Needs Review A pull request which needs code review. labels May 1, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

No coverage information available.

@kgryte
Copy link
Copy Markdown
Member

kgryte commented May 2, 2026

As the CI failure is not due to changes introduced in this PR, I'll go ahead and merge.

@kgryte kgryte merged commit 987f182 into develop May 2, 2026
36 of 37 checks passed
@kgryte kgryte deleted the philipp/fix-commit-review-2026-04-29 branch May 2, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements, additions, or changes to documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants