-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: add constants/float16/nan
#9265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
Hey @GlyphicGuy , I open a PR for this #9096 |
|
Heyy @DivyanshuVortex , I think you have not referenced the #9061 in you PR, so I was not aware a about a PR open for the same thing. I see that you are already a contributor and I am trying to make my first contribution here, just wondering if this can be worked out? |
|
You’re right — I didn’t reference the issue, my mistake. When I opened the PR, the issue hadn’t been approved by the maintainer therefore i didn't ref the issue , but the PR was already open. |
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/stdlib update-copyright-years |
Signed-off-by: Athan <kgryte@gmail.com>
|
@kgryte Thank you so much for merging my PR. This counts as my first contribution to stdlib and I'm excited to learn and contribute better! |
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves a part of #9061
Description
This pull request:
add constants/float16/nanRelated Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers