Skip to content

chore(work-items): EPIC-03 refinement — address non-blocking PR review feedback#107

Merged
steilerDev merged 1 commit into
betafrom
chore/3-refinement
Feb 17, 2026
Merged

chore(work-items): EPIC-03 refinement — address non-blocking PR review feedback#107
steilerDev merged 1 commit into
betafrom
chore/3-refinement

Conversation

@steilerDev
Copy link
Copy Markdown
Owner

Summary

Addresses non-blocking review observations collected from EPIC-03 PRs (#97-#106).

Backend fixes

  • Escape SQL LIKE wildcards (%, _) in search queries
  • Extract shared ensureWorkItemExists() helper
  • Add DFS iteration limits (10K max) to cycle detection
  • Move self-reference check before DB queries
  • Rename cyclePathcycle for API contract compliance

Frontend fixes

  • Fix action menu click-outside detection (shared ref issue)
  • Replace alert()/confirm() with custom modals
  • Add modifier key guard (Ctrl/Alt/Meta) to keyboard shortcuts
  • Initialize selectedIndex to -1 (no default selection)
  • Combine duplicate Delete/Backspace help entries
  • Remove console.error in TagPicker, use error state
  • Differentiate empty state vs no-results on list page

Test plan

  • All existing tests pass (1072 tests)
  • Lint, typecheck, format all clean
  • No new functionality — refinement only

🤖 Generated with Claude Code

- Escape SQL LIKE wildcards in search queries
- Extract shared ensureWorkItemExists helper
- Add DFS iteration limits to cycle detection
- Move self-reference check before DB queries
- Rename cyclePath to cycle for API contract compliance

Co-Authored-By: Claude backend-developer (Opus 4.6) <noreply@anthropic.com>
@steilerDev steilerDev merged commit 82fe614 into beta Feb 17, 2026
4 checks passed
@steilerDev steilerDev deleted the chore/3-refinement branch February 17, 2026 11:33
@github-actions
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.8.0-beta.10 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants